try to fix github.com/vuejs/vue/issues/6353 #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add `_renderStyles` property on context, so that we could define `styles` property in `vue-server-renderer`
|
Sorry, your original fix idea was better... I introduced a regression in my fix. Should've merged yours instead :) |
|
Would you like to explain what's wrong with your original fix? |
|
The original fix was checking the presence of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
No
If relevant, did you update the README?
No
Summary
add
_renderStylesproperty on context, so that we could definestylesproperty invue-server-rendererDoes this PR introduce a breaking change?
No